Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

If we get a 405 doing an HTTP PATCH, assume the server is pre-1.9 and… #13615

Merged
merged 2 commits into from
Jan 11, 2022
Merged

If we get a 405 doing an HTTP PATCH, assume the server is pre-1.9 and… #13615

merged 2 commits into from
Jan 11, 2022

Conversation

ncabatoff
Copy link
Collaborator

… fall back to old readThenWrite approach. Fixes #13502

@ncabatoff ncabatoff added this to the 1.9.3 milestone Jan 10, 2022
@ncabatoff ncabatoff requested a review from ccapurso January 10, 2022 18:44
@vercel vercel bot temporarily deployed to Preview – vault-storybook January 10, 2022 18:52 Inactive
@vercel vercel bot temporarily deployed to Preview – vault January 10, 2022 18:52 Inactive
ccapurso
ccapurso approved these changes Jan 10, 2022
View reviewed changes
Copy link
Contributor

@ccapurso ccapurso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@ncabatoff ncabatoff merged commit 9ef8ee0 into main Jan 11, 2022
@ncabatoff ncabatoff deleted the fix-kv-patch-backwards-compat branch January 11, 2022 16:52
ncabatoff added a commit that referenced this pull request Jan 11, 2022
@ncabatoff
If we get a 405 doing an HTTP PATCH, assume the server is pre-1.9 and…
00e63eb 
… fall back to old readThenWrite approach (#13615)
@ncabatoff ncabatoff mentioned this pull request Jan 11, 2022
Merged
heppu pushed a commit to heppu/vault that referenced this pull request Jan 13, 2022
@ncabatoff @heppu
If we get a 405 doing an HTTP PATCH, assume the server is pre-1.9 and…
7a32483 
… fall back to old readThenWrite approach (hashicorp#13615)
ncabatoff added a commit that referenced this pull request Jan 13, 2022
@ncabatoff
If we get a 405 doing an HTTP PATCH, assume the server is pre-1.9 and…
b8b09c0 
… fall back to old readThenWrite approach (#13615) (#13629)
@thiskevinwang thiskevinwang mentioned this pull request Apr 25, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ccapurso ccapurso ccapurso approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.9.3
Development

Successfully merging this pull request may close these issues.

Vault cli kv patch performs call to api v1
2 participants
@ncabatoff @ccapurso